Issue 10826055: Issue 4090. For-in loop variable should not be visible in iterable expression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10826055: Issue 4090. For-in loop variable should not be visible in iterable expression. (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4090. For-in loop variable should not be visible in iterable expression. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10002

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java	View		1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 4 months ago (2012-07-28 14:48:47 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10826055/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java
(right):

https://chromiumcodereview.appspot.com/10826055/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/resolver/NegativeResolverTest.java:1350:
public void test_forEachVaraibleIsNotVisibleInIterableExpression() throws
Exception {
minor typo: "Varaible" --> "Variable"

Expand Messages | Collapse Messages