Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 10826023: Change #library("dom") to #library("dart:dom_deprecated") . (Closed)

Created:
8 years, 5 months ago by dgrove
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change #library("dom") to #library("dart:dom_deprecated") . Change #library("html") to #library("dart:html") . Fix issue 4194. Committed: https://code.google.com/p/dart/source/detail?r=9919

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M lib/dom/dart2js/dom_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/dom.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/templates/dom/dart2js/dart2js_dom.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/templates/dom/dummy/dom_dummy.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/doc/html.dartdoc View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/html_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/html_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dgrove
8 years, 5 months ago (2012-07-25 23:18:52 UTC) #1
Jennifer Messerly
On 2012/07/25 23:18:52, dgrove wrote: does it really make sense to have the names be ...
8 years, 5 months ago (2012-07-25 23:21:16 UTC) #2
Siggi Cherem (dart-lang)
lgtm to fix the problems, but I agree with John
8 years, 5 months ago (2012-07-25 23:40:06 UTC) #3
Johnni Winther
8 years, 5 months ago (2012-07-26 06:14:56 UTC) #4
On 2012/07/25 23:21:16, John Messerly wrote:
> On 2012/07/25 23:18:52, dgrove wrote:
> 
> does it really make sense to have the names be "dart:foo"? we don't name
> libraries "package:bar" even though that's how you import them, instead we
name
> them #library('bar')
> 
> anyway if so then all of these would need to be changed right?
> http://api.dartlang.org/
> 
> regarding dart:dom, I thought it was unused at this point?

All libraries recognized by dart2js have been updated to use the dart: prefix in
https://chromiumcodereview.appspot.com/10809035/. This change has not been
deployed into api.dartlang.org yet.

Powered by Google App Engine
This is Rietveld 408576698