Add --use_cha (default true, switch to false if you use dynamic class loading). Use CHA to specify …

Add --use_cha (default true, switch to false if you use dynamic class loading). Use CHA to specify receiver class if no subclasses of the receiver exist, eliminate check class computation.
Remove all optimized code whenever we load scripts/libraries/snapshots. Currently this occurs only when no Dart frame is live on stack. Future change (deoptimization) will allow dynamic class loading in presence of live Dart frames.
The cost of removing all optimized code is supposed to be low. If that assumptions turns out to be false I can add more elaborate tracking of optimized functions.
Committed: https://code.google.com/p/dart/source/detail?r=11106

[regis, 2012-08-21 20:52:21]

LGTM

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:3755: intptr_t num_cids = class_table.NumCids();
const

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:881: intptr_t cid =
Class::Handle(param_type.type_class()).id();
const

[siva, 2012-08-21 21:39:19]

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:3780: }
These checks on every load library/script/source seem pretty heavy weight, do
you know what the impact on startup time is with this change?

Why not keep a flag in the isolate optimized_code_exists_, set it when optimized
code is generated and then you can skip RemoveOptimziedCode if
optimized_code_exists_ is false.
(that way it won't repeatedly call the loop too).

[srdjan, 2012-08-21 22:08:15]

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
File runtime/vm/dart_api_impl.cc (right):

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:3755: intptr_t num_cids = class_table.NumCids();
On 2012/08/21 20:52:21, regis wrote:
> const

Done.

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/dart_api_im...
runtime/vm/dart_api_impl.cc:3780: }
On 2012/08/21 21:39:19, asiva wrote:
> These checks on every load library/script/source seem pretty heavy weight, do
> you know what the impact on startup time is with this change?
> 
> Why not keep a flag in the isolate optimized_code_exists_, set it when
optimized
> code is generated and then you can skip RemoveOptimziedCode if
> optimized_code_exists_ is false.
> (that way it won't repeatedly call the loop too).

No difference seen in CorelibIsolateStartup.

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_optimizer.cc (right):

https://chromiumcodereview.appspot.com/10825483/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_optimizer.cc:881: intptr_t cid =
Class::Handle(param_type.type_class()).id();
On 2012/08/21 20:52:21, regis wrote:
> const

Done.

[siva, 2012-08-21 22:21:11]

lgtm

[srdjan, 2012-08-21 22:31:39]

Added also the forgotten _x64 file.. same code as in ia32 version reviewed.