Issue 10825473: Fix dart:io Process class on the Windows plaform, which had some race conditions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825473: Fix dart:io Process class on the Windows plaform, which had some race conditions. (Closed)

Created:
8 years, 4 months ago by Bill Hesse

Modified:
8 years, 4 months ago

Reviewers:
Søren Gjesse, Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart:io Process class on the Windows plaform, which had some race conditions. BUG=dart:4414 Committed: https://code.google.com/p/dart/source/detail?r=11050

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	runtime/bin/process_win.cc	View		3 chunks	+9 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

8 years, 4 months ago (2012-08-21 14:33:47 UTC) #3

DBC

https://chromiumcodereview.appspot.com/10825473/diff/1/runtime/bin/process_wi...
File runtime/bin/process_win.cc (right):

https://chromiumcodereview.appspot.com/10825473/diff/1/runtime/bin/process_wi...
runtime/bin/process_win.cc:515: return true;  // The process has already died. 
Report a successful kill.
Returning true here is inconsistent with linux/mac. Either update the
process.kill comment or change?

Expand Messages | Collapse Messages