More mirrors changes to bring vm mirrors more in line with the

More mirrors changes to bring vm mirrors more in line with the
current proposed mirrors api.
Committed: https://code.google.com/p/dart/source/detail?r=11095

[cshapiro, 2012-08-21 03:16:04]

Not sure where things are at.  Presumably we will discuss some of the naming
issues in the morrow.

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart
File lib/mirrors/mirrors.dart (right):

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:325: * An immutable map from names to mirrors for all
setter
could call this (and above) mapping to get rid of implementation details your
call.

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:415: final bool isUnboundType;
isGenericDeclaration

or

isDefinition

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:425: final ClassMirror unboundType;
The verbiage in the comments seems better than the variable name.  We have
talked about

genericDeclaration

and

definition

for this particular member.

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:459: * The bound of the reflectee.
I am not sure what this means from the comment.  It seems ambiguous.

http://codereview.chromium.org/10825431/diff/2002/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

http://codereview.chromium.org/10825431/diff/2002/runtime/lib/mirrors_impl.da...
runtime/lib/mirrors_impl.dart:505: String get qualifiedName() {
  // The simple name and the qualified name are the same for a library.
  String get qualifiedName() => simpleName;

For consistency with the other accessors?

http://codereview.chromium.org/10825431/diff/2002/runtime/lib/mirrors_impl.da...
runtime/lib/mirrors_impl.dart:731: // TODO(rmacnak): Fill these mirrors will
real information
Still relevant?  Should this be a TODO(turnidge)?

[turnidge, 2012-08-21 18:00:48]

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart
File lib/mirrors/mirrors.dart (right):

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:325: * An immutable map from names to mirrors for all
setter
On 2012/08/21 03:16:05, cshapiro wrote:
> could call this (and above) mapping to get rid of implementation details your
> call.

Since the type is listed below, I'm not sure if the distinction between map and
mapping is important to me here.

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:415: final bool isUnboundType;
On 2012/08/21 03:16:05, cshapiro wrote:
> isGenericDeclaration
> 
> or
> 
> isDefinition

Choosing isGenericDeclaration for now.

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:425: final ClassMirror unboundType;
On 2012/08/21 03:16:05, cshapiro wrote:
> The verbiage in the comments seems better than the variable name.  We have
> talked about
> 
> genericDeclaration
> 
> and
> 
> definition
> 
> for this particular member.

I'm changing it to genericDeclaration for now.

http://codereview.chromium.org/10825431/diff/2002/lib/mirrors/mirrors.dart#ne...
lib/mirrors/mirrors.dart:459: * The bound of the reflectee.
On 2012/08/21 03:16:05, cshapiro wrote:
> I am not sure what this means from the comment.  It seems ambiguous.

Changed to upperBound and improved comment.

http://codereview.chromium.org/10825431/diff/2002/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

http://codereview.chromium.org/10825431/diff/2002/runtime/lib/mirrors_impl.da...
runtime/lib/mirrors_impl.dart:505: String get qualifiedName() {
On 2012/08/21 03:16:05, cshapiro wrote:
>   // The simple name and the qualified name are the same for a library.
>   String get qualifiedName() => simpleName;
> 
> For consistency with the other accessors?

Switched all short functions (that can fit on one line) to use the => format in
the file.

http://codereview.chromium.org/10825431/diff/2002/runtime/lib/mirrors_impl.da...
runtime/lib/mirrors_impl.dart:731: // TODO(rmacnak): Fill these mirrors will
real information
On 2012/08/21 03:16:05, cshapiro wrote:
> Still relevant?  Should this be a TODO(turnidge)?

Will change these unimplemented accessors to throw NotImplemented and drop the
todo.