Issue 10825422: Don't pollute repo with temp dirs for pub tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825422: Don't pollute repo with temp dirs for pub tests. (Closed)

Created:
8 years, 4 months ago by Bob Nystrom

Modified:
8 years, 4 months ago

Reviewers:
dgrove, Bill Hesse, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't pollute repo with temp dirs for pub tests. Committed: https://code.google.com/p/dart/source/detail?r=10997

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	utils/pub/io.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download
	M	utils/tests/pub/test_pub.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

This fixes: http://code.google.com/p/dart/issues/detail?id=4559

8 years, 4 months ago (2012-08-17 17:16:33 UTC) #1

Bill Hesse

8 years, 4 months ago (2012-08-21 10:34:07 UTC) #3

I don't think using the system temp directory is a good solution to this
problem, because that directory eventually fills up with garbage (perhaps slowly
in this case, so it won't really cause a problem).

For the other tests, we have put them in generated_tests in the build directory.
 If you need to do this from inside a test, you can use the path of the Dart
shell executable, which can be gotten from the Options class in dart:core.  This
also solves the problem of multiple instances (different architectures and
modes) being run at once - they have different build directories.

Expand Messages | Collapse Messages