Issue 10825346: Fix bugs in parser and update tests to use new directive syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825346: Fix bugs in parser and update tests to use new directive syntax (Closed)

Created:
8 years, 4 months ago by Brian Wilkerson

Modified:
8 years, 4 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bugs in parser and update tests to use new directive syntax. Note that the changes in TypeAnalyzer exist to keep the tests running and are probably something you need to fix. Committed: https://code.google.com/p/dart/source/detail?r=10678

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -203 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/DefaultLibrarySource.java	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartImportDirective.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/ast/DartLibraryDirective.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	6 chunks	+28 lines, -8 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/testing/TestLibrarySource.java	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/common/ApplicationSourceFileTest.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java	View	25 chunks	+71 lines, -71 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/my.app.dart	View	1 chunk	+11 lines, -11 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/my.merged.app.dart	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/my.nuke5.app.dart	View	1 chunk	+9 lines, -9 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/my.prefixed.app.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/my.unprefixed.app.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/some.lib.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/some.prefixable.lib.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/some.prefixable.modified.lib.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.lib.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/AbstractParserTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/Directives.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/Directives2.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/LibraryParserTest.java	View	3 chunks	+12 lines, -12 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/ParserRecoveryTest.java	View	4 chunks	+12 lines, -26 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/QualifiedReturnTypeB.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/parser/SyntaxTest.java	View	2 chunks	+2 lines, -13 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages