Drt Windows status updated

Drt Windows status updated

Committed: https://code.google.com/p/dart/source/detail?r=10873

[sra1, 2012-08-14 13:31:23]

Are these test configurations new configurations that were not previously
tested, or are these test configurations that have gone bad?

If they have gone bad, what change caused them to go bad and why is that not
being fixed instead?

https://chromiumcodereview.appspot.com/10825341/diff/1/tests/html/html.status
File tests/html/html.status (right):

https://chromiumcodereview.appspot.com/10825341/diff/1/tests/html/html.status...
tests/html/html.status:35: shadow_dom_test: Skip # No ShadowDOM support except
on tip dartium.
Should not be skipped.  Our drt *is* tip of dartium.

https://chromiumcodereview.appspot.com/10825341/diff/1/tests/html/html.status...
tests/html/html.status:36: shadow_dom_layout_test: Skip
ditto

[ahe, 2012-08-14 17:53:46]

Hi Stephen,

Some background:

Johnni is using Windows as his primary computer. This is good, because this
platform is in the need of a lot of love from the Dart team.

Today we discovered that the automated download of DRT is not working on
Windows, and that this problem is known and has been ignored (see:
http://code.google.com/p/dart/issues/detail?id=3166).

Now what does this mean? It means that DRT is *never* updated automatically on
the build bots.

On 2012/08/14 13:31:23, sra1 wrote:
> Are these test configurations new configurations that were not previously
> tested, or are these test configurations that have gone bad?

I'm not entirely sure, I'm currently trying to document what is being tested on
the browser build bots (you can follow my progress here:
http://code.google.com/p/dart/wiki/TestingDart2js).

As far as I know, we are not testing --compiler=dart2js --runtime=drt on the
build bots, but if we are, drt is not up-to-date on the Windows builders.

So, right now, I'm assuming these tests aren't being run on the build bot.
Submitting this CL would be part of testing that hypothesis.

> If they have gone bad, what change caused them to go bad and why is that not
> being fixed instead?

I don't know if these tests ever ran on DRT/Windows. If they did, I think the
change is something in Dartium/Chromium/DRT that broke while we didn't run these
tests on the build bots.

Cheers,
Peter

> https://chromiumcodereview.appspot.com/10825341/diff/1/tests/html/html.status
> File tests/html/html.status (right):
> 
>
https://chromiumcodereview.appspot.com/10825341/diff/1/tests/html/html.status...
> tests/html/html.status:35: shadow_dom_test: Skip # No ShadowDOM support except
> on tip dartium.
> Should not be skipped.  Our drt *is* tip of dartium.
> 
>
https://chromiumcodereview.appspot.com/10825341/diff/1/tests/html/html.status...
> tests/html/html.status:36: shadow_dom_layout_test: Skip
> ditto

[ahe, 2012-08-14 17:54:15]

Hi Johnni,

Looks like we need to take a second look based on Stephen's comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10825341/diff/1/samples/tests/samples/...
File samples/tests/samples/samples.status (right):

https://chromiumcodereview.appspot.com/10825341/diff/1/samples/tests/samples/...
samples/tests/samples/samples.status:63: swarm/swarm_test: Fail
This is bad. Let's investigate it.

[Johnni Winther, 2012-08-15 13:13:00]

PTAL

http://codereview.chromium.org/10825341/diff/1/tests/html/html.status
File tests/html/html.status (right):

http://codereview.chromium.org/10825341/diff/1/tests/html/html.status#newcode35
tests/html/html.status:35: shadow_dom_test: Skip # No ShadowDOM support except
on tip dartium.
On 2012/08/14 13:31:23, sra1 wrote:
> Should not be skipped.  Our drt *is* tip of dartium.

indexeddb_2_test copied to dart2js/drt/windows

[ahe, 2012-08-15 14:35:27]

LGTM if you restore the section in html.status.

http://codereview.chromium.org/10825341/diff/5002/tests/html/html.status
File tests/html/html.status (left):

http://codereview.chromium.org/10825341/diff/5002/tests/html/html.status#oldc...
tests/html/html.status:192: [ $compiler == dart2js && ($runtime == drt ||
$runtime == ff) && $system == linux]
I don't think you can remove this section any more.

[Johnni Winther, 2012-08-17 08:40:12]

http://codereview.chromium.org/10825341/diff/5002/tests/html/html.status
File tests/html/html.status (left):

http://codereview.chromium.org/10825341/diff/5002/tests/html/html.status#oldc...
tests/html/html.status:192: [ $compiler == dart2js && ($runtime == drt ||
$runtime == ff) && $system == linux]
On 2012/08/15 14:35:27, ahe wrote:
> I don't think you can remove this section any more.

Done.