Issue 10825339: Fix issue 4456 (BadNumberFormatException -> FormatException).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825339: Fix issue 4456 (BadNumberFormatException -> FormatException). (Closed)

Created:
8 years, 4 months ago by kasperl

Modified:
8 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix issue 4456 (BadNumberFormatException -> FormatException). R=lrn@google.com BUG=http://dartbug.com/4456 Committed: https://code.google.com/p/dart/source/detail?r=10625

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+377 lines, -114 lines)			Patch
M	lib/compiler/implementation/lib/math.dartp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/corelib/math_parse_double_test.dart	View	1 chunk	+118 lines, -111 lines	0 comments	Download
M	tests/corelib/math_test.dart	View	2 chunks	+256 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

8 years, 4 months ago (2012-08-14 10:27:12 UTC) #2

LGTM and thanks.

https://chromiumcodereview.appspot.com/10825339/diff/1/tests/corelib/math_tes...
File tests/corelib/math_test.dart (right):

https://chromiumcodereview.appspot.com/10825339/diff/1/tests/corelib/math_tes...
tests/corelib/math_test.dart:7: // class entirely.
Which is Real Soon Now.
Otherwise I'd suggest parameterizing each test by a function and passing either
math.sin or Math.sin to it.

Expand Messages | Collapse Messages