Issue 10825178: Change EXPECT(!Dart_IsError(...)) to EXPECT_VALID(...) in VM tests.

Issue 10825178: Change EXPECT(!Dart_IsError(...)) to EXPECT_VALID(...) in VM tests. (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change EXPECT(!Dart_IsError(...)) to EXPECT_VALID(...) in VM tests. This change will give better error messages when the expectation fails in the tests. EXPECT_VALID prints the error. R=iposva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10276

Patch Set 1 #

Total comments: 4

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -28 lines)			Patch
M	runtime/vm/benchmark_test.cc	View	7 chunks	+15 lines, -13 lines	2 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	runtime/vm/debugger_api_impl_test.cc	View	9 chunks	+10 lines, -10 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://chromiumcodereview.appspot.com/10825178/diff/1/runtime/vm/benchmark_test.cc File runtime/vm/benchmark_test.cc (right): https://chromiumcodereview.appspot.com/10825178/diff/1/runtime/vm/benchmark_test.cc#newcode349 runtime/vm/benchmark_test.cc:349: Dart_Handle int64_result = Dart_IntegerToInt64(result, &elapsed_time); ...

8 years, 4 months ago (2012-08-03 18:59:47 UTC) #2

Kevin Millikin (Google)

8 years, 4 months ago (2012-08-06 07:49:46 UTC) #3

https://chromiumcodereview.appspot.com/10825178/diff/1/runtime/vm/benchmark_t...
File runtime/vm/benchmark_test.cc (right):

https://chromiumcodereview.appspot.com/10825178/diff/1/runtime/vm/benchmark_t...
runtime/vm/benchmark_test.cc:349: Dart_Handle int64_result =
Dart_IntegerToInt64(result, &elapsed_time);
On 2012/08/03 18:59:47, Ivan Posva wrote:
> result = Dart_IntegerToInt64(result, &elapsed_time);
> EXPECT_VALID(result);

Done.

https://chromiumcodereview.appspot.com/10825178/diff/1/runtime/vm/debugger_ap...
File runtime/vm/debugger_api_impl_test.cc (right):

https://chromiumcodereview.appspot.com/10825178/diff/1/runtime/vm/debugger_ap...
runtime/vm/debugger_api_impl_test.cc:21: #define EXPECT_NOT_ERROR(handle)       
                                      \
On 2012/08/03 18:59:47, Ivan Posva wrote:
> Please just remove the use of EXPECT_NOT_ERROR and replace it with
EXPECT_VALID.

Done.

Expand Messages | Collapse Messages