Issue 10825139: Free the C memory for ArchiveInputStream when the stream is garbage collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10825139: Free the C memory for ArchiveInputStream when the stream is garbage collected. (Closed)

Created:
8 years, 4 months ago by nweiz

Modified:
8 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Free the C memory for ArchiveInputStream when the stream is garbage collected. Committed: https://code.google.com/p/dart/source/detail?r=10149

Patch Set 1 #

Patch Set 2 : Fix a renamed function #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+118 lines, -11 lines)			Patch
M	utils/archive/dart_archive.c	View	1	2 chunks	+41 lines, -0 lines	0 comments	Download
M	utils/archive/input_stream.dart	View		6 chunks	+12 lines, -9 lines	1 comment	Download
M	utils/archive/reader.c	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	utils/archive/utils.dart	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	utils/tests/archive/utils_test.dart	View		1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

8 years, 4 months ago (2012-08-01 23:52:36 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10825139/diff/2001/utils/archive/input...
File utils/archive/input_stream.dart (right):

https://chromiumcodereview.appspot.com/10825139/diff/2001/utils/archive/input...
utils/archive/input_stream.dart:37: ArchiveInputStream(int id) : _id = new
Reference<int>(id),
How about moving : to the next line and not indenting these so far?

Expand Messages | Collapse Messages