Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1218)

Issue 10825112: Issue 4262. Support for --version in dart_analyzer (Closed)

Created:
8 years, 4 months ago by scheglov
Modified:
8 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -3 lines) Patch
M compiler/java/com/google/dart/compiler/CommandLineOptions.java View 2 chunks +8 lines, -0 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DartCompiler.java View 5 chunks +37 lines, -3 lines 4 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 4 months ago (2012-07-31 19:15:23 UTC) #1
Brian Wilkerson
LGTM, though I'd prefer to have the error messages changed https://chromiumcodereview.appspot.com/10825112/diff/1/compiler/java/com/google/dart/compiler/DartCompiler.java File compiler/java/com/google/dart/compiler/DartCompiler.java (right): https://chromiumcodereview.appspot.com/10825112/diff/1/compiler/java/com/google/dart/compiler/DartCompiler.java#newcode1362 ...
8 years, 4 months ago (2012-07-31 19:28:24 UTC) #2
scheglov
8 years, 4 months ago (2012-07-31 19:39:06 UTC) #3
https://chromiumcodereview.appspot.com/10825112/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

https://chromiumcodereview.appspot.com/10825112/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:1362:
System.out.println("dart_analyzer #" + revision);

> I think it would be better to have a message like:
> 
>   dart_analyzer version {revision}

OK

> 
> for the normal case and a message like:
> 
>   dart_analyzer version unknown
>   Could not find the SDK, please set the DART_SDK environment variable or
>   use the --dart-sdk command-line option.

Actually dart_analyzer script will print error like this is can not find SDK,
even before running Java code.

https://chromiumcodereview.appspot.com/10825112/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/DartCompiler.java:1366: * @return the
numeric revision of SDK, may be <code>null</code> if can not find.
On 2012/07/31 19:28:25, Brian Wilkerson wrote:
> nit: "can not" --> "cannot"

Done.

Powered by Google App Engine
This is Rietveld 408576698