fix support for --package-root command line option to analyzer dartbug.com/4225

fix support for --package-root command line option to analyzer
Committed: https://code.google.com/p/dart/source/detail?r=9981

[scheglov, 2012-07-27 04:21:53]

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/DartCompiler.java:1096: libraryManager =
((DefaultCompilerConfiguration) config).getSystemLibraryManager();
Why not add getSystemLibraryManager() to CompilerConfiguration?
It seems that every implementation has SystemLibraryManager anyway.

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java
(right):

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java:141: *
@return the systemLibraryManager
Useless comment.

[keertip, 2012-07-27 15:51:47]

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/DartCompiler.java (right):

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/DartCompiler.java:1096: libraryManager =
((DefaultCompilerConfiguration) config).getSystemLibraryManager();
On 2012/07/27 04:21:53, scheglov wrote:
> Why not add getSystemLibraryManager() to CompilerConfiguration?
> It seems that every implementation has SystemLibraryManager anyway.

Done.

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
File compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java
(right):

http://codereview.chromium.org/10825054/diff/2001/compiler/java/com/google/da...
compiler/java/com/google/dart/compiler/DefaultCompilerConfiguration.java:141: *
@return the systemLibraryManager
Removed

On 2012/07/27 04:21:53, scheglov wrote:
> Useless comment.

[danrubel, 2012-07-27 16:13:04]

lgtm

[scheglov, 2012-07-27 17:00:47]

lgtm