Issue 10824399: Implement TypeVariableElement.position.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824399: Implement TypeVariableElement.position. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Johnni Winther, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Implement TypeVariableElement.position. R=ahe@google.com,johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=11044

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	lib/compiler/implementation/elements/elements.dart	View		1 chunk	+2 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

https://chromiumcodereview.appspot.com/10824399/diff/1/lib/compiler/implementation/elements/elements.dart File lib/compiler/implementation/elements/elements.dart (right): https://chromiumcodereview.appspot.com/10824399/diff/1/lib/compiler/implementation/elements/elements.dart#newcode1514 lib/compiler/implementation/elements/elements.dart:1514: Token position() => findMyName(enclosingElement.position()); I think this should be: ...

8 years, 4 months ago (2012-08-21 14:06:37 UTC) #3

Anton Muhin

8 years, 4 months ago (2012-08-21 14:08:27 UTC) #4

https://chromiumcodereview.appspot.com/10824399/diff/1/lib/compiler/implement...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10824399/diff/1/lib/compiler/implement...
lib/compiler/implementation/elements/elements.dart:1514: Token position() =>
findMyName(enclosingElement.position());
Fresh CL sent to you and Johnni.

On 2012/08/21 14:06:37, ahe wrote:
> I think this should be:
> 
> Token position() => cachedNode.getBeginToken();

Expand Messages | Collapse Messages