Issue 10824367: Add all api docs from pkg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824367: Add all api docs from pkg (Closed)

Created:
8 years, 4 months ago by Jennifer Messerly

Modified:
8 years, 4 months ago

Reviewers:
Johnni Winther, dgrove

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add all api docs from pkg. Right now we only have "intl" and "unittest". This changes the code to find all of them. Committed: https://code.google.com/p/dart/source/detail?r=11090

Patch Set 2 : improved error handling #

Total comments: 2

Patch Set 3 : merged and removed i18n #

Patch Set 4 : removed todo as well #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -15 lines)			Patch
	M	utils/apidoc/apidoc.dart	View	1 2 3	1 chunk	+26 lines, -15 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dgrove

lgtm https://chromiumcodereview.appspot.com/10824367/diff/2001/utils/apidoc/apidoc.dart File utils/apidoc/apidoc.dart (right): https://chromiumcodereview.appspot.com/10824367/diff/2001/utils/apidoc/apidoc.dart#newcode120 utils/apidoc/apidoc.dart:120: if (libname == 'i18n') libname = 'intl'; This ...

8 years, 4 months ago (2012-08-21 18:42:31 UTC) #2

Jennifer Messerly

thanks! giving it one more test after merge, then landing https://chromiumcodereview.appspot.com/10824367/diff/2001/utils/apidoc/apidoc.dart File utils/apidoc/apidoc.dart (right): https://chromiumcodereview.appspot.com/10824367/diff/2001/utils/apidoc/apidoc.dart#newcode120 ...

8 years, 4 months ago (2012-08-21 18:50:13 UTC) #3

lgtm