Issue 10824350: Fix some type warnings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824350: Fix some type warnings. (Closed)

Created:
8 years, 4 months ago by karlklose

Modified:
8 years, 4 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix some type warnings. Committed: https://code.google.com/p/dart/source/detail?r=11028

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -8 lines)			Patch
M	lib/compiler/implementation/elements/elements.dart	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/patch_parser.dart	View	1 chunk	+1 line, -1 line	1 comment	Download
M	lib/compiler/implementation/resolver.dart	View	1 chunk	+3 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 4 months ago (2012-08-20 15:23:16 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10824350/diff/1/lib/compiler/implement...
File lib/compiler/implementation/patch_parser.dart (right):

https://chromiumcodereview.appspot.com/10824350/diff/1/lib/compiler/implement...
lib/compiler/implementation/patch_parser.dart:214: AbstractFieldElement field =
existing;
Anders already fixed this, I think.

https://chromiumcodereview.appspot.com/10824350/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10824350/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1955: ClassElement superelement =
supertype.element;
superelement -> superElement.

Expand Messages | Collapse Messages