Issue 10824329: dart2dart properly collect top level fields

Issue 10824329: dart2dart properly collect top level fields (Closed)

Created:
8 years, 4 months ago by Roman

Modified:
8 years, 4 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2dart properly collect top level fields Committed: https://code.google.com/p/dart/source/detail?r=10810

Patch Set 4 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
	M	lib/compiler/implementation/dart_backend/placeholder_collector.dart	View	1 2 3	2 chunks	+11 lines, -0 lines	0 comments	Download
	M	tests/compiler/dart2js/unparser_test.dart	View	1 2 3	5 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

lgtm w/ comments addressed https://chromiumcodereview.appspot.com/10824329/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart File lib/compiler/implementation/dart_backend/placeholder_collector.dart (right): https://chromiumcodereview.appspot.com/10824329/diff/1/lib/compiler/implementation/dart_backend/placeholder_collector.dart#newcode185 lib/compiler/implementation/dart_backend/placeholder_collector.dart:185: assert(false); // Unreachable. nit: internalError, ...

8 years, 4 months ago (2012-08-16 11:05:47 UTC) #2

Roman

8 years, 4 months ago (2012-08-16 11:46:09 UTC) #3

https://chromiumcodereview.appspot.com/10824329/diff/1/lib/compiler/implement...
File lib/compiler/implementation/dart_backend/placeholder_collector.dart
(right):

https://chromiumcodereview.appspot.com/10824329/diff/1/lib/compiler/implement...
lib/compiler/implementation/dart_backend/placeholder_collector.dart:185:
assert(false); // Unreachable.
On 2012/08/16 11:05:48, Anton Muhin wrote:
> nit: internalError, please

Done.

https://chromiumcodereview.appspot.com/10824329/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/unparser_test.dart (right):

https://chromiumcodereview.appspot.com/10824329/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/unparser_test.dart:230: var globalVar;
On 2012/08/16 11:05:48, Anton Muhin wrote:
> just for fun, let's try variable lists, something (if everything is allowed)
> like:
> 
> var var0 = 0, var1, var2 = 2;

Done.

Expand Messages | Collapse Messages