Issue 10824326: Enable (HTML)DataListElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824326: Enable (HTML)DataListElement (Closed)

Created:
8 years, 4 months ago by sra1

Modified:
8 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable (HTML)DataListElement Add test and convenience constructor. Fixes Issue 4474. Committed: https://code.google.com/p/dart/source/detail?r=10786

Patch Set 2 : #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -0 lines)			Patch
M	lib/dom/dart2js/dom_dart2js.dart	View	4 chunks	+19 lines, -0 lines	0 comments	Download
M	lib/dom/dom.dart	View	2 chunks	+12 lines, -0 lines	2 comments	Download
M	lib/dom/scripts/fremontcutbuilder.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/html/dart2js/html_dart2js.dart	View	5 chunks	+29 lines, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View	5 chunks	+35 lines, -0 lines	0 comments	Download
A	tests/html/datalistelement_test.dart	View	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with check https://chromiumcodereview.appspot.com/10824326/diff/2001/lib/dom/dom.dart File lib/dom/dom.dart (right): https://chromiumcodereview.appspot.com/10824326/diff/2001/lib/dom/dom.dart#newcode3984 lib/dom/dom.dart:3984: final HTMLElement list; Just to be ...

8 years, 4 months ago (2012-08-16 17:45:05 UTC) #2

sra1

8 years, 4 months ago (2012-08-16 18:49:54 UTC) #3

https://chromiumcodereview.appspot.com/10824326/diff/2001/lib/dom/dom.dart
File lib/dom/dom.dart (right):

https://chromiumcodereview.appspot.com/10824326/diff/2001/lib/dom/dom.dart#ne...
lib/dom/dom.dart:3984: final HTMLElement list;
On 2012/08/16 17:45:05, Emily Fortuna wrote:
> Just to be sure -- we want this to be HTMLElement and not just Element?

This file, 'dom.dart', is what remains of the straight-forward non-renaming
dart:dom.  So HTMLElement is correct (like HTMLFormElement above).

Expand Messages | Collapse Messages

Issue 10824326: Enable (HTML)DataListElement (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages