Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 10824275: Revert "Refactor Library/CompilationUnit and how we define local Scope." (Closed)

Created:
8 years, 4 months ago by Anders Johnsen
Modified:
8 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Refactor Library/CompilationUnit and how we define local Scope." This reverts commit 05718e680ca45ac26fcc0d0256fc98419fac1b2e. BUG= Committed: https://code.google.com/p/dart/source/detail?r=10550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -165 lines) Patch
M lib/compiler/implementation/compiler.dart View 6 chunks +22 lines, -18 lines 0 comments Download
M lib/compiler/implementation/elements/elements.dart View 12 chunks +83 lines, -100 lines 0 comments Download
M lib/compiler/implementation/enqueue.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/js_backend/native_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/native_handler.dart View 2 chunks +4 lines, -5 lines 0 comments Download
M lib/compiler/implementation/patch_parser.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M lib/compiler/implementation/resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/class_element_parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/listener.dart View 1 chunk +4 lines, -8 lines 0 comments Download
M lib/compiler/implementation/scanner/scanner_task.dart View 6 chunks +13 lines, -16 lines 0 comments Download
M lib/dartdoc/mirrors/dart2js_mirror.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/co19/co19-leg.status View 6 chunks +29 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/find_my_name_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/parser_helper.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Anders Johnsen
TBR
8 years, 4 months ago (2012-08-13 06:45:08 UTC) #1
Søren Gjesse
8 years, 4 months ago (2012-08-13 06:52:57 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698