Issue 10824234: Reapply "Collect call site information and use that for estimating parameter types"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824234: Reapply "Collect call site information and use that for estimating parameter types" (Closed)

Created:
8 years, 4 months ago by Søren Gjesse

Modified:
8 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Collect call site information and use that for estimating parameter types" This reapplies r10386 and r10383 which was reverted in r10394 It also fixes the bug causing the revert. This is the line 1754 added in codegen.dart. Also added a regression test. R=kasperl@google.com BUG=4434 Committed: https://code.google.com/p/dart/source/detail?r=10443

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+312 lines, -11 lines)			Patch
M	lib/compiler/implementation/compiler.dart	View	4 chunks	+113 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View	3 chunks	+16 lines, -0 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1 chunk	+9 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/universe.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download
A	tests/compiler/dart2js/call_site_type_inferer_test.dart	View	1 chunk	+151 lines, -0 lines	0 comments	Download
A +	tests/compiler/dart2js_extra/regress/4434_lib.dart	View	1 chunk	+4 lines, -5 lines	0 comments	Download
A	tests/compiler/dart2js_extra/regress/4434_test.dart	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages