Issue 10824201: Verify at method exit that stack size is the same as at entry, except for methods with finally clau…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824201: Verify at method exit that stack size is the same as at entry, except for methods with finally clau… (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Verify at method exit that stack size is the same as at entry, except for methods with finally clauses. Mark functions that have finally clauses as they may produce extra values on stack. Note that we currently do not optimize methods with finally clauses and therefore there are no issues related to incorrect stack size at deoptimization. Committed: https://code.google.com/p/dart/source/detail?r=10351

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -4 lines)			Patch
M	runtime/vm/flow_graph_compiler.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	runtime/vm/object.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/raw_object.h	View	2 chunks	+13 lines, -4 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 4 months ago (2012-08-07 19:48:12 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10824201/diff/1/runtime/vm/raw_object.h
File runtime/vm/raw_object.h (right):

https://chromiumcodereview.appspot.com/10824201/diff/1/runtime/vm/raw_object....
runtime/vm/raw_object.h:631: void SetKind(Kind value) {
Not related to your change but we need an assertion that
kConstImplicitGetter or some kMaxFunctionKind
is <= ((1 << kKindTagSize) - 1)

Expand Messages | Collapse Messages