Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 10824165: Ensure that ia32 build passes all tests with --use-ssa on. (Closed)

Created:
8 years, 4 months ago by Vyacheslav Egorov (Google)
Modified:
8 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure that ia32 build passes all tests with --use-ssa on. Bugs fixed in register allocator: - incorrect assertions in SplitAt; - allocation finger should not cache positions that are owned by a sibling after split; - UpdateFreeUntil should allow evicting live range with vreg 0; - values expected in fixed locations should not cause an interference at the instruction itself, they can be evicted if need arises; Bug fixed in deoptimization: - parallel move resolver uses push/pop to free a scratch register for memory to memory moves, when using it for deoptimization we need to ensure that those push/pops do not interfere with actual moves; R=srdjan@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10287

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -21 lines) Patch
M runtime/vm/flow_graph_allocator.h View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_allocator.cc View 11 chunks +48 lines, -14 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 2 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vyacheslav Egorov (Google)
8 years, 4 months ago (2012-08-03 15:33:48 UTC) #1
srdjan
8 years, 4 months ago (2012-08-03 16:56:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698