Issue 10824148: Reapply "Use platform-independent format specifiers when disassembling code objects."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824148: Reapply "Use platform-independent format specifiers when disassembling code objects." (Closed)

Created:
8 years, 4 months ago by Kevin Millikin (Google)

Modified:
8 years, 4 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reapply "Use platform-independent format specifiers when disassembling code objects." This reapplies svn revision 10163 with a fix for Windows. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10174

Patch Set 1 #

Patch Set 2 : Test for PRIdPTR being defined before #defining it. #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -43 lines)			Patch
M	runtime/include/dart_api.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/platform/globals.h	View	1	2 chunks	+18 lines, -7 lines	1 comment	Download
M	runtime/vm/compiler.cc	View		2 chunks	+22 lines, -28 lines	0 comments	Download
M	runtime/vm/object.cc	View		2 chunks	+9 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

https://chromiumcodereview.appspot.com/10824148/diff/6/runtime/platform/globals.h File runtime/platform/globals.h (right): https://chromiumcodereview.appspot.com/10824148/diff/6/runtime/platform/globals.h#newcode113 runtime/platform/globals.h:113: #if defined(TARGET_OS_WINDOWS) PRIdPTR was not defined here before. PRIdPTR ...

8 years, 4 months ago (2012-08-02 14:57:27 UTC) #1

lgtm

Expand Messages | Collapse Messages