Issue 10824128: Eagerly get the function and code corresponding to the frame elements in a stack trace so that we w…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824128: Eagerly get the function and code corresponding to the frame elements in a stack trace so that we w… (Closed)

Created:
8 years, 4 months ago by siva

Modified:
8 years, 4 months ago

Reviewers:
srdjan, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Eagerly get the function and code corresponding to the frame elements in a stack trace so that we won't be doing expensive code object lookups when setting up the stack trace. Committed: https://code.google.com/p/dart/source/detail?r=10248

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -15 lines)			Patch
M	vm/exceptions.cc	View	2 chunks	+18 lines, -4 lines	1 comment	Download
M	vm/object.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	vm/object.cc	View	5 chunks	+19 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

8 years, 4 months ago (2012-08-03 20:49:53 UTC) #3

https://chromiumcodereview.appspot.com/10824128/diff/5001/vm/exceptions.cc
File vm/exceptions.cc (right):

https://chromiumcodereview.appspot.com/10824128/diff/5001/vm/exceptions.cc#ne...
vm/exceptions.cc:32: const GrowableObjectArray& code_list) {
How about this:
FindExceptionHandler(...
    const GrowableObjectArray& func_list,
    const GrowableObjectArray& code_list,
    const GrowableObjectArray& pc_offset_list)

Expand Messages | Collapse Messages