Get basic Windows stuff working.

Get basic Windows stuff working.

Enable pub tests that do appear to currently pass on Windows.

Committed: https://code.google.com/p/dart/source/detail?r=10100

[Bob Nystrom, 2012-07-30 22:48:36]

This enables the tests that don't require any Windows-specific sauce and fixes a
couple of minor bugs that break anything working on Windows.

[nweiz, 2012-07-30 23:03:39]

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:30: final parts = _getPath(part1).replaceAll('\\',
'/').split('/');
It feels like maybe this should be part of _getPath? That way anything in here
that uses string paths can assume that they have forward slashes.

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:155: return ensureDir(dirname(path)).chain((p) {
I don't understand why you've named this variable, or why you've increased the
nesting here.

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:257: if (platform == 'windows') dartBin =
'$dartBin.exe';
Are you sure this will work on the buildbots?

[Bob Nystrom, 2012-07-30 23:42:33]

Thanks!

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/pub/io.dart
File utils/pub/io.dart (right):

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:30: final parts = _getPath(part1).replaceAll('\\',
'/').split('/');
On 2012/07/30 23:03:39, nweiz wrote:
> It feels like maybe this should be part of _getPath? That way anything in here
> that uses string paths can assume that they have forward slashes.

I'm hesitant to normalize paths eagerly really early in code paths like that. If
that path ends up getting reflected back to the user, they may be confused that
it isn't what they entered.

I think dart:io can correctly handle either form, so we generally just pass
paths along as they are. This is one of the few cases where our code itself
cares about the path separator.

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/pub/io.dart#newc...
utils/pub/io.dart:155: return ensureDir(dirname(path)).chain((p) {
On 2012/07/30 23:03:39, nweiz wrote:
> I don't understand why you've named this variable, or why you've increased the
> nesting here.

The "p" is leftover debug code. Removed.

The nesting change is actually a behavioral change. It makes sure we only call
createDir() when the directory doesn't exist. Before it was always doing that.

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/tests/pub/test_p...
File utils/tests/pub/test_pub.dart (right):

https://chromiumcodereview.appspot.com/10824095/diff/1/utils/tests/pub/test_p...
utils/tests/pub/test_pub.dart:257: if (platform == 'windows') dartBin =
'$dartBin.exe';
On 2012/07/30 23:03:39, nweiz wrote:
> Are you sure this will work on the buildbots?

This is just adding ".exe" to the end. It should work, I hope.

[nweiz, 2012-07-31 00:20:13]

lgtm