Issue 10824078: Add explicit PushArgument IL instructions to static calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824078: Add explicit PushArgument IL instructions to static calls. (Closed)

Created:
8 years, 4 months ago by Florian Schneider

Modified:
8 years, 4 months ago

Reviewers:
Kevin Millikin (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add explicit PushArgument IL instructions to static calls. This enables compiling static calls with the SSA-based code generator. Add a helper to the graph builder for adding argument expressions to the graph. Committed: https://code.google.com/p/dart/source/detail?r=10008

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -45 lines)			Patch
M	vm/flow_graph_allocator.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	vm/flow_graph_builder.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	vm/flow_graph_builder.cc	View	10 chunks	+40 lines, -30 lines	0 comments	Download
M	vm/il_printer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/intermediate_language.h	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	vm/intermediate_language.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages