Issue 10823411: Fixed issue 4580 introduced by revision 10894.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823411: Fixed issue 4580 introduced by revision 10894. (Closed)

Created:
8 years, 4 months ago by zerny-google

Modified:
8 years, 4 months ago

Reviewers:
Vyacheslav Egorov (Google), srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fixed issue 4580 introduced by revision 10894. Binds of constants are dereferenced before adding them as inputs to phis. R=srdjan@google.com,vegorov@google.com BUG=dart:4580 Committed: https://code.google.com/p/dart/source/detail?r=10977

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -5 lines)			Patch
	M	runtime/vm/flow_graph.cc	View		4 chunks	+18 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

zerny-google

This should fix bug http://code.google.com/p/dart/issues/detail?id=4580

8 years, 4 months ago (2012-08-20 14:44:38 UTC) #1

srdjan

8 years, 4 months ago (2012-08-20 16:54:20 UTC) #3

LGTM with one comment

http://codereview.chromium.org/10823411/diff/1/runtime/vm/flow_graph.cc
File runtime/vm/flow_graph.cc (right):

http://codereview.chromium.org/10823411/diff/1/runtime/vm/flow_graph.cc#newco...
runtime/vm/flow_graph.cc:292: // Helper to either use the constant value of a
defintion or the defintion.
s/defintion/definition/ (twice)

Expand Messages | Collapse Messages