Issue 10823399: Add pubspec files to args and dartdoc .

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823399: Add pubspec files to args and dartdoc . (Closed)

Created:
8 years, 4 months ago by dgrove

Modified:
8 years, 4 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add pubspec files to args and dartdoc . Committed: https://code.google.com/p/dart/source/detail?r=10928

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	A	pkg/args/pubspec.yaml	View		1 chunk	+9 lines, -0 lines	1 comment	Download
	A	pkg/dartdoc/pubspec.yaml	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

8 years, 4 months ago (2012-08-17 21:00:16 UTC) #2

lgtm, other than one issue with the markdown in the description

https://chromiumcodereview.appspot.com/10823399/diff/4001/pkg/args/pubspec.yaml
File pkg/args/pubspec.yaml (right):

https://chromiumcodereview.appspot.com/10823399/diff/4001/pkg/args/pubspec.ya...
pkg/args/pubspec.yaml:4: a set of options and values using [GNU][] and [POSIX][]
style options.
probably should copy the GNU and POSIX links or remove the brackets (do we
intend to have markdown in the description field? how long should the
description be?)

 * [posix]:
http://pubs.opengroup.org/onlinepubs/009695399/basedefs/xbd_chap12.html#tag_1...
 * [gnu]:
http://www.gnu.org/prep/standards/standards.html#Command_002dLine-Interfaces

Expand Messages | Collapse Messages