Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10823343: Improve a reason for failure. (Closed)

Created:
8 years, 4 months ago by Anton Muhin
Modified:
8 years, 4 months ago
Reviewers:
Roman
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tests/language/language.status View 2 chunks +1 line, -2 lines 3 comments Download

Messages

Total messages: 4 (0 generated)
Anton Muhin
8 years, 4 months ago (2012-08-15 13:58:08 UTC) #1
Roman
lgtm https://chromiumcodereview.appspot.com/10823343/diff/1/tests/language/language.status File tests/language/language.status (left): https://chromiumcodereview.appspot.com/10823343/diff/1/tests/language/language.status#oldcode227 tests/language/language.status:227: syntax_test/47: Fail # We should get compile-time error ...
8 years, 4 months ago (2012-08-15 14:00:45 UTC) #2
Anton Muhin
https://chromiumcodereview.appspot.com/10823343/diff/1/tests/language/language.status File tests/language/language.status (left): https://chromiumcodereview.appspot.com/10823343/diff/1/tests/language/language.status#oldcode227 tests/language/language.status:227: syntax_test/47: Fail # We should get compile-time error on ...
8 years, 4 months ago (2012-08-15 14:02:28 UTC) #3
Roman
8 years, 4 months ago (2012-08-15 14:13:35 UTC) #4
lgtm

https://chromiumcodereview.appspot.com/10823343/diff/1/tests/language/languag...
File tests/language/language.status (left):

https://chromiumcodereview.appspot.com/10823343/diff/1/tests/language/languag...
tests/language/language.status:227: syntax_test/47: Fail  # We should get
compile-time error on const constructor having body. But we don't emit default
constructors with empty body.
On 2012/08/15 14:02:28, Anton Muhin wrote:
> I thought about that be decided against: it's apparently compile-time error to
> see const A() {}, so it should be treated in parser/resolver, not in dart
> backend.
> 
> Thoughts?
> 
> On 2012/08/15 14:00:45, Roman wrote:
> > Actually we can fix this failure reason if we emit empty constructors. So
> that's
> > probably dart2dart fault, not dart2js
> 

Agreed that it should be compiler-time error.

Powered by Google App Engine
This is Rietveld 408576698