Issue 10823324: Added Smi, Mint and Double types to object store.

Issue 10823324: Added Smi, Mint and Double types to object store. (Closed)

Created:
8 years, 4 months ago by srdjan

Modified:
8 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added Smi, Mint and Double types to object store. Committed: https://code.google.com/p/dart/source/detail?r=10687

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -9 lines)			Patch
M	runtime/vm/intermediate_language.cc	View	1	1 chunk	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1	3 chunks	+12 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/intermediate_language.cc#newcode809 runtime/vm/intermediate_language.cc:809: // TODO(srdjan): Add mint, smi and double type ...

8 years, 4 months ago (2012-08-14 21:56:33 UTC) #2

srdjan

8 years, 4 months ago (2012-08-14 22:52:08 UTC) #3

Thanks!

https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.cc (right):

https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.cc:809: // TODO(srdjan): Add mint, smi and
double type to object store.
On 2012/08/14 21:56:33, regis wrote:
> Remove TODO.

Done.

https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/object_store.h
File runtime/vm/object_store.h (right):

https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/object_stor...
runtime/vm/object_store.h:79: static intptr_t smi_class_offset() {
On 2012/08/14 21:56:33, regis wrote:
> I do not think we use this getter anymore.

Removed

https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/object_stor...
runtime/vm/object_store.h:98: double_type_ = value.raw();
On 2012/08/14 21:56:33, regis wrote:
> one line?

Done.

https://chromiumcodereview.appspot.com/10823324/diff/1/runtime/vm/object_stor...
runtime/vm/object_store.h:105: void set_mint_type(const Type& value) {
On 2012/08/14 21:56:33, regis wrote:
> one line?

Done.

Expand Messages | Collapse Messages