Support resolution of indexed operators.

Support resolution of indexed operators.

Committed: https://code.google.com/p/dart/source/detail?r=10634

[kasperl, 2012-08-14 07:13:13]

LGTM.

https://chromiumcodereview.appspot.com/10823293/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10823293/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1319: } else {
Turn this into else-if and move Selector.INDEX_AND_INDEX_SET to the left side of
the === comparison for consistency.

https://chromiumcodereview.appspot.com/10823293/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1321: register(op, selector) {
This looks fine for now, but I'll probably have to change it a bit.

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/resolver_test.dart (right):

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:730: compileScript(String source,
f(compiler)) {
Could this just return the compiler instead?

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:738: compileScript(@"class C {
toString() => 'C'; } main() { '${new C()}'; }",
Maybe stuff the script code in a string variable to make the callback argument
more readable.

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:750: compileScript(@"""
Separate string variable for the script code.

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:758:
.lookupLocalMember(buildSourceString(@'operator$index'));
It would be nice if you didn't have to hardcode the operator$index and the
operator$indexSet names here. Can you use Elements.constructOperatorName
instead? I'd rather hardcode [] and []=.

[Anton Muhin, 2012-08-14 11:34:44]

Thanks a lot for review, Kasper, submitting

https://chromiumcodereview.appspot.com/10823293/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10823293/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1319: } else {
On 2012/08/14 07:13:13, kasperl wrote:
> Turn this into else-if and move Selector.INDEX_AND_INDEX_SET to the left side
of
> the === comparison for consistency.

Done.

https://chromiumcodereview.appspot.com/10823293/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:1321: register(op, selector) {
On 2012/08/14 07:13:13, kasperl wrote:
> This looks fine for now, but I'll probably have to change it a bit.

Sure

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
File tests/compiler/dart2js/resolver_test.dart (right):

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:730: compileScript(String source,
f(compiler)) {
On 2012/08/14 07:13:13, kasperl wrote:
> Could this just return the compiler instead?

Done.

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:738: compileScript(@"class C {
toString() => 'C'; } main() { '${new C()}'; }",
Hopefully obsolete after addressing your previous comment.

On 2012/08/14 07:13:13, kasperl wrote:
> Maybe stuff the script code in a string variable to make the callback argument
> more readable.

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:750: compileScript(@"""
On 2012/08/14 07:13:13, kasperl wrote:
> Separate string variable for the script code.

Done.

https://chromiumcodereview.appspot.com/10823293/diff/1/tests/compiler/dart2js...
tests/compiler/dart2js/resolver_test.dart:758:
.lookupLocalMember(buildSourceString(@'operator$index'));
On 2012/08/14 07:13:13, kasperl wrote:
> It would be nice if you didn't have to hardcode the operator$index and the
> operator$indexSet names here. Can you use Elements.constructOperatorName
> instead? I'd rather hardcode [] and []=.

Done.