Issue 10823288: Speculative fix for dartc problem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823288: Speculative fix for dartc problem. (Closed)

Created:
8 years, 4 months ago by Anton Muhin

Modified:
8 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Speculative fix for dartc problem. TBR=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=10576

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Bill Hesse

8 years, 4 months ago (2012-08-13 14:51:38 UTC) #2

LGTM.
I think the problem might have been that args is a shared object, and you need
to make a new list that is a copy of it.
Or maybe args is an immutable list, or not a list.

Expand Messages | Collapse Messages