Issue 10823276: Exclude language/naming_test on firefox and safari

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823276: Exclude language/naming_test on firefox and safari (Closed)

Created:
8 years, 4 months ago by hausner

Modified:
8 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Exclude language/naming_test on firefox and safari No idea why a purely language test fails on those when it passes on all other suites. Maybe a name collision in the generated JS code on certain JS implementations? Committed: https://code.google.com/p/dart/source/detail?r=10536

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/language/language_dart2js.status	View		2 chunks	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

http://codereview.chromium.org/10823276/diff/1/tests/language/language_dart2js.status File tests/language/language_dart2js.status (right): http://codereview.chromium.org/10823276/diff/1/tests/language/language_dart2js.status#newcode266 tests/language/language_dart2js.status:266: naming_test: Fail Did you File an issue about this/add ...

8 years, 4 months ago (2012-08-10 22:02:08 UTC) #3

hausner

8 years, 4 months ago (2012-08-10 22:10:38 UTC) #4

Updated bug 4454.

http://codereview.chromium.org/10823276/diff/1/tests/language/language_dart2j...
File tests/language/language_dart2js.status (right):

http://codereview.chromium.org/10823276/diff/1/tests/language/language_dart2j...
tests/language/language_dart2js.status:266: naming_test: Fail
On 2012/08/10 22:02:08, Emily Fortuna wrote:
> Did you File an issue about this/add a comment? I filed 4454...

Thanks for filing this. I added a comment to the bug.

Expand Messages | Collapse Messages