Issue 10823269: - Improve generated sources:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823269: - Improve generated sources: (Closed)

Created:
8 years, 4 months ago by Ivan Posva

Modified:
8 years, 4 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Improve generated sources: + Strip private key from identifiers. + Properly handle strings with interpolation. - Keep private key in the token stream and properly snapshot. Committed: https://code.google.com/p/dart/source/detail?r=10515

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -26 lines)			Patch
M	lib/arrays.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/object.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	vm/object.cc	View	8 chunks	+71 lines, -22 lines	0 comments	Download
M	vm/object_test.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	vm/raw_object_snapshot.cc	View	2 chunks	+5 lines, -0 lines	2 comments	Download
M	vm/snapshot_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM https://chromiumcodereview.appspot.com/10823269/diff/1/vm/raw_object_snapshot.cc File vm/raw_object_snapshot.cc (right): https://chromiumcodereview.appspot.com/10823269/diff/1/vm/raw_object_snapshot.cc#newcode621 vm/raw_object_snapshot.cc:621: // Rean in the private key in use ...

8 years, 4 months ago (2012-08-10 16:13:01 UTC) #2

Ivan Posva

8 years, 4 months ago (2012-08-10 16:57:20 UTC) #3

Thanks,
-Ivan

https://chromiumcodereview.appspot.com/10823269/diff/1/vm/raw_object_snapshot.cc
File vm/raw_object_snapshot.cc (right):

https://chromiumcodereview.appspot.com/10823269/diff/1/vm/raw_object_snapshot...
vm/raw_object_snapshot.cc:621: // Rean in the private key in use by the token
stream.
On 2012/08/10 16:13:01, hausner wrote:
> Rean -> Read

Done.

Expand Messages | Collapse Messages