Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 10823258: Match input operand count of BranchInstr with the input location count. (Closed)

Created:
8 years, 4 months ago by Florian Schneider
Modified:
8 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Match input operand count of BranchInstr with the input location count. For now this is achieved by making the branch instruction push its arguments itself in the case it performs an instance call. Also remove the result location from the location summary of BranchInstr in the instance call case since it does never produce a result. Committed: https://code.google.com/p/dart/source/detail?r=10488

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M vm/intermediate_language_ia32.cc View 3 chunks +12 lines, -3 lines 1 comment Download
M vm/intermediate_language_x64.cc View 3 chunks +12 lines, -3 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
8 years, 4 months ago (2012-08-09 16:50:57 UTC) #1
Vyacheslav Egorov (Google)
lgtm
8 years, 4 months ago (2012-08-09 19:29:20 UTC) #2
srdjan
8 years, 4 months ago (2012-08-09 19:56:49 UTC) #3
DBC

https://chromiumcodereview.appspot.com/10823258/diff/1/vm/intermediate_langua...
File vm/intermediate_language_ia32.cc (right):

https://chromiumcodereview.appspot.com/10823258/diff/1/vm/intermediate_langua...
vm/intermediate_language_ia32.cc:2007: locs->set_in(1,
Location::RegisterLocation(ECX));
Why do you require EAX, ECX to hold inputs?

https://chromiumcodereview.appspot.com/10823258/diff/1/vm/intermediate_langua...
File vm/intermediate_language_x64.cc (right):

https://chromiumcodereview.appspot.com/10823258/diff/1/vm/intermediate_langua...
vm/intermediate_language_x64.cc:2013: locs->set_in(1,
Location::RegisterLocation(RCX));
ditto

Powered by Google App Engine
This is Rietveld 408576698