Issue 10823216: Disable one missed co19 FormatException test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823216: Disable one missed co19 FormatException test. (Closed)

Created:
8 years, 4 months ago by Bob Nystrom

Modified:
8 years, 4 months ago

Reviewers:
ahe, Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable one missed co19 FormatException test. Committed: https://code.google.com/p/dart/source/detail?r=10361

Patch Set 2 : Respond to review. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
M	tests/co19/co19-compiler.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Looks like I missed one. Not sure why the VM was OK with this still ...

8 years, 4 months ago (2012-08-07 22:15:48 UTC) #1

Emily Fortuna

lgtm with tweak https://chromiumcodereview.appspot.com/10823216/diff/1/tests/co19/co19-runtime.status File tests/co19/co19-runtime.status (right): https://chromiumcodereview.appspot.com/10823216/diff/1/tests/co19/co19-runtime.status#newcode14 tests/co19/co19-runtime.status:14: [ $runtime == vm ] probably ...

8 years, 4 months ago (2012-08-07 22:17:17 UTC) #2