Issue 10823140: Make more native DOM array-like objects known to compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823140: Make more native DOM array-like objects known to compiler. (Closed)

Created:
8 years, 4 months ago by sra1

Modified:
8 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make more native DOM array-like objects known to compiler. This improves Dromaeo traversal benchmarks up from ~100 to ~160. (They still need more work - target is ~400.) Committed: https://code.google.com/p/dart/source/detail?r=10158

Patch Set 1 #

Total comments: 2

Patch Set 2 : indentation #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -8 lines)			Patch
	M	lib/dom/scripts/systemhtml.py	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
	M	lib/html/dart2js/html_dart2js.dart	View		8 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM! https://chromiumcodereview.appspot.com/10823140/diff/1/lib/dom/scripts/systemhtml.py File lib/dom/scripts/systemhtml.py (right): https://chromiumcodereview.appspot.com/10823140/diff/1/lib/dom/scripts/systemhtml.py#newcode1007 lib/dom/scripts/systemhtml.py:1007: self._interface, self._database) 4 space indent here?

8 years, 4 months ago (2012-08-02 10:03:06 UTC) #2

sra1

8 years, 4 months ago (2012-08-02 10:26:51 UTC) #3

https://chromiumcodereview.appspot.com/10823140/diff/1/lib/dom/scripts/system...
File lib/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/10823140/diff/1/lib/dom/scripts/system...
lib/dom/scripts/systemhtml.py:1007: self._interface, self._database)
On 2012/08/02 10:03:06, kasperl wrote:
> 4 space indent here?

Done.

Expand Messages | Collapse Messages