Issue 10823127: Issue 4300. Support for 'external' keyword

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823127: Issue 4300. Support for 'external' keyword (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4300. Support for 'external' keyword http://code.google.com/p/dart/issues/detail?id=4300 R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=10144

Patch Set 1 #

Total comments: 1

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+89 lines, -7 lines)			Patch
M	compiler/java/com/google/dart/compiler/ast/Modifiers.java	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View	12 chunks	+23 lines, -6 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/parser/ParserErrorCode.java	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/Resolver.java	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	2 chunks	+58 lines, -0 lines	1 comment	Download
M	tests/language/language.status	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 4 months ago (2012-08-01 21:15:00 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10823127/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/10823127/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:3211:
public void test_externalKeyword_bad() throws Exception {
Not in this method, but we might want to test that "external" cannot be applied
to fields.

Expand Messages | Collapse Messages