Issue 10823028: - Improve the formatting of generated source text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10823028: - Improve the formatting of generated source text. (Closed)

Created:
8 years, 5 months ago by Ivan Posva

Modified:
8 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

- Improve the formatting of generated source text. Committed: https://code.google.com/p/dart/source/detail?r=9952

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+97 lines, -7 lines)			Patch
M	runtime/vm/dart.cc	View	3 chunks	+30 lines, -0 lines	1 comment	Download
M	runtime/vm/object.cc	View	2 chunks	+64 lines, -4 lines	0 comments	Download
M	runtime/vm/token.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

siva

8 years, 5 months ago (2012-07-26 00:51:05 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10823028/diff/1/runtime/vm/dart.cc
File runtime/vm/dart.cc (right):

https://chromiumcodereview.appspot.com/10823028/diff/1/runtime/vm/dart.cc#new...
runtime/vm/dart.cc:118: }
In the non snapshot case the print-bootstrap flat prints in the following
format:

  if (FLAG_print_bootstrap) {
    OS::Print("Bootstrap source '%s':\n%s\n",
        String::Handle(script.url()).ToCString(),
        String::Handle(script.Source()).ToCString());
  }

We should probably make the two consistent, Also I don't think the non snapshot
version prints dart:io etc.

I would think the best option might be to remove the existing implementation and
always call this new code in both cases from here.

Expand Messages | Collapse Messages