Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 10821130: Revert "Update status for IE" (Closed)

Created:
8 years, 4 months ago by vsm
Modified:
8 years, 4 months ago
Reviewers:
Emily Fortuna, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Update status for IE" These tests mysteriously started working in r9839 and breaking again when I partially rolled it back in r10118. Only IE is affected. On the surface, the change (noSuchMethod on a DOM type) looks completely unrelated to the tests, but it's obviously causing a lot of unintended changes. It was rolled back due to massive code size increase. TBR=kasperl,efortuna I'll file a bug. Committed: https://code.google.com/p/dart/source/detail?r=10120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M tests/language/language_dart2js.status View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
vsm
8 years, 4 months ago (2012-08-01 16:16:18 UTC) #1
Emily Fortuna
8 years, 4 months ago (2012-08-01 17:03:21 UTC) #2
lgtm. Does this mean that the IE perf tests won't be working quite right now?

Powered by Google App Engine
This is Rietveld 408576698