Ensure that we never try to split range at its end position.

Ensure that we never try to split range at its end position.

Move parallel moves corresponding to gotos and block entries into this intructions to separate them from normal parallel moves that are used data flow inside basic blocks.

Block fixed locations only from instruction's start to instruction end (not to the start of the next instruction). 

R=fschneider@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=10065

[Florian Schneider, 2012-07-31 15:31:59]

LGTM.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_allocator.cc (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:547: // Expected sfhape of live range:
Accidental edit?

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:1099: if (to == range->End()) to -= 1;
A comment would be good here.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:2639: if (!current->IsReturn()) {
This is not part of the fix. I'd remove it.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:2526: // connect live ranges at the start of
the block.
s/start/end/

[srdjan, 2012-07-31 15:58:35]

DBC

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_allocator.cc (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:334: cpu_regs_[reg][0]->AddUseInterval(pos,
pos + 1);
Please add comment about the interval range (beginning of instruction to end of
instruction?).

[Vyacheslav Egorov (Google), 2012-07-31 16:18:49]

Thanks for the review.

Comments addressed, landing.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_allocator.cc (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:334: cpu_regs_[reg][0]->AddUseInterval(pos,
pos + 1);
On 2012/07/31 15:58:35, srdjan wrote:
> Please add comment about the interval range (beginning of instruction to end
of
> instruction?).

Done.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:547: // Expected sfhape of live range:
On 2012/07/31 15:31:59, Florian Schneider wrote:
> Accidental edit?

Done.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_allocator.cc:1099: if (to == range->End()) to -= 1;
On 2012/07/31 15:31:59, Florian Schneider wrote:
> A comment would be good here.

Done.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
File runtime/vm/flow_graph_builder.cc (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/flow_graph_...
runtime/vm/flow_graph_builder.cc:2639: if (!current->IsReturn()) {
On 2012/07/31 15:31:59, Florian Schneider wrote:
> This is not part of the fix. I'd remove it.

Done.

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/intermediat...
File runtime/vm/intermediate_language.h (right):

https://chromiumcodereview.appspot.com/10821108/diff/1/runtime/vm/intermediat...
runtime/vm/intermediate_language.h:2526: // connect live ranges at the start of
the block.
On 2012/07/31 15:31:59, Florian Schneider wrote:
> s/start/end/

Done.