Issue 10820064: Fix issue 977

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10820064: Fix issue 977 (Closed)

Created:
8 years, 4 months ago by hausner

Modified:
8 years, 4 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 977 Constructors with redirection may not have a function body. Committed: https://code.google.com/p/dart/source/detail?r=9999

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	runtime/vm/parser.cc	View		2 chunks	+8 lines, -0 lines	2 comments	Download
	M	tests/co19/co19-runtime.status	View		2 chunks	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

cshapiro

8 years, 4 months ago (2012-07-27 23:17:12 UTC) #2

lgtm

http://codereview.chromium.org/10820064/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10820064/diff/1/runtime/vm/parser.cc#newcode2403
runtime/vm/parser.cc:2403: "Constructor with redirection may not have function
body");
This might read better with the indefinite article.  Consider this alternative

  "Constructor with redirection may not have a function body"

http://codereview.chromium.org/10820064/diff/1/runtime/vm/parser.cc#newcode2428
runtime/vm/parser.cc:2428: "Constructor with redirection may not have function
body");
ditto

Expand Messages | Collapse Messages