Refactor callback emission.

Refactor callback emission.

Move most of the logic into common part.

Committed: https://code.google.com/p/dart/source/detail?r=9882

[Anton Muhin, 2012-07-25 12:43:01]

Pavel, tbring, but I would really appreciate your feedback.

[podivilov1, 2012-08-21 10:28:53]

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:670: requires_stack_info = False
There is too many flags coming from different places. Would be nice to cleanup
this list, e.g. separate flags that affect c++ parameter list from flags
affecting native callback code structure.

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:730:
cpp_arguments.append('DartUtilities::processingUserGesture');
semicolon :)

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:785: '        Document* document =
domWindow->document();\n')
Personally, I don't like splitting c++ parameter definitions generation from
parameter list building. Maybe introduce a builder class as discussed
previously?

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:843: if argument_name == 'default':
This is fragile because it differs from what v8 generator does. Setter argument
name should always be 'value'.

[Anton Muhin, 2012-08-21 12:09:49]

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
File lib/dom/scripts/systemnative.py (right):

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:670: requires_stack_info = False
Agree.  BTW, please, have a look at the latest version, it looks readable enough
for me, but YMMV.

On 2012/08/21 10:28:53, podivilov1 wrote:
> There is too many flags coming from different places. Would be nice to cleanup
> this list, e.g. separate flags that affect c++ parameter list from flags
> affecting native callback code structure.

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:730:
cpp_arguments.append('DartUtilities::processingUserGesture');
Oops.

On 2012/08/21 10:28:53, podivilov1 wrote:
> semicolon :)

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:785: '        Document* document =
domWindow->document();\n')
I overall agree, but there were some unpleasant changes which make it somewhat
hard to place document/scriptExecution context into the correct place, hence the
split logic.

On 2012/08/21 10:28:53, podivilov1 wrote:
> Personally, I don't like splitting c++ parameter definitions generation from
> parameter list building. Maybe introduce a builder class as discussed
> previously?

https://chromiumcodereview.appspot.com/10818037/diff/3001/lib/dom/scripts/sys...
lib/dom/scripts/systemnative.py:843: if argument_name == 'default':
I don't think it's a big problem to be different from v8 here, anything I am
missing?

On 2012/08/21 10:28:53, podivilov1 wrote:
> This is fragile because it differs from what v8 generator does. Setter
argument
> name should always be 'value'.