Issue 10818032: Adjust location summaries to match expectations of new register allocator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10818032: Adjust location summaries to match expectations of new register allocator. (Closed)

Created:
8 years, 5 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adjust location summaries to match expectations of new register allocator. Instructions containing calls can only use fixed registers everything else is blocked and unavailable for allocation. Insert phi-connecting parallel moves after all instructions were numbered otherwise move gets incorrect position. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9856

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+87 lines, -51 lines)			Patch
M	runtime/vm/flow_graph_allocator.cc	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	9 chunks	+41 lines, -23 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	9 chunks	+39 lines, -21 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Google)

This fixes crashes in checked mode. Please take a look.

8 years, 5 months ago (2012-07-24 17:08:15 UTC) #1

LGTM

Expand Messages | Collapse Messages