Issue 10817019: Provide noSuchMethod hook for UnknownElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10817019: Provide noSuchMethod hook for UnknownElement (Closed)

Created:
8 years, 5 months ago by vsm

Modified:
8 years, 5 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Provide noSuchMethod hook for UnknownElement The test passes on dartium, fails on dart2js. The latter appears to be a dart2js bug related to noSuchMethod. Still need to update the html.status file. TEST=unknownelement_test.dart Committed: https://code.google.com/p/dart/source/detail?r=9839

Patch Set 1 #

Patch Set 2 : Add template #

Patch Set 3 : Remove erroneous static #

Total comments: 1

Patch Set 4 : Update status #

Patch Set 5 : Rename dartObjectLocalStorage to xtag #

Patch Set 6 : Fix typos #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -1 line)			Patch
A	lib/dom/templates/html/impl/impl_UnknownElement.darttemplate	View	1 2 3 4 5	1 chunk	+21 lines, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	lib/html/frog/html_frog.dart	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/html/unknownelement_test.dart	View	1 2 3 4 5	1 chunk	+72 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jacob

8 years, 5 months ago (2012-07-24 01:18:27 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10817019/diff/4001/lib/dom/templates/h...
File lib/dom/templates/html/impl/impl_UnknownElement.darttemplate (right):

https://chromiumcodereview.appspot.com/10817019/diff/4001/lib/dom/templates/h...
lib/dom/templates/html/impl/impl_UnknownElement.darttemplate:12: var
dartObjectLocalStorage;
rename 

dartObjectLocalStorage

to 

xtag

Expand Messages | Collapse Messages