Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10816034: Basic 'Quick Fix' support and one fix as example/test (Closed)

Created:
8 years, 5 months ago by scheglov
Modified:
8 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Basic 'Quick Fix' support and one fix as example/test Also use ErrorCdoe instead of "problemId" integer. R=messick@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9865

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+863 lines, -489 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/index/AnalysisMarkerManager.java View 2 chunks +3 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/operation/ReconcileWorkingCopyOperation.java View 1 chunk +2 lines, -3 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/problem/DefaultProblem.java View 4 chunks +4 lines, -9 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/problem/Problem.java View 2 chunks +3 lines, -1 line 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/utilities/ast/DartElementLocator.java View 1 chunk +1 line, -1 line 1 comment Download
M editor/tools/plugins/com.google.dart.tools.ui/plugin.xml View 2 chunks +37 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/internal/corext/codemanipulation/OrganizeImportsOperation.java View 5 chunks +11 lines, -9 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/ContributedProcessorDescriptor.java View 2 chunks +4 lines, -2 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.java View 1 chunk +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/CorrectionMessages.properties View 1 chunk +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/DartCorrectionAssistant.java View 3 chunks +139 lines, -134 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/DartCorrectionProcessor.java View 11 chunks +218 lines, -202 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/ProblemLocation.java View 5 chunks +14 lines, -13 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickAssistProcessor.java View 3 chunks +6 lines, -6 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/QuickFixProcessor.java View 1 chunk +123 lines, -0 lines 0 comments Download
A editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/correction/proposals/MarkerResolutionProposal.java View 1 chunk +95 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/CompilationUnitDocumentProvider.java View 7 chunks +26 lines, -20 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/DartMarkerAnnotation.java View 4 chunks +33 lines, -5 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/editor/IJavaAnnotation.java View 2 chunks +3 lines, -4 lines 1 comment Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/spelling/SpellingQuickFixProcessor.java View 5 chunks +2 lines, -70 lines 2 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/IProblemLocation.java View 2 chunks +2 lines, -1 line 1 comment Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/text/dart/IQuickFixProcessor.java View 2 chunks +2 lines, -1 line 1 comment Download
A editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/correction/QuickFixProcessorTest.java View 1 chunk +130 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/correction/TestAll.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
8 years, 5 months ago (2012-07-24 15:22:41 UTC) #1
messick
LGTM with some minor cleanup. https://chromiumcodereview.appspot.com/10816034/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/problem/DefaultProblem.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/problem/DefaultProblem.java (right): https://chromiumcodereview.appspot.com/10816034/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/problem/DefaultProblem.java#newcode2 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/problem/DefaultProblem.java:2: * Copyright (c) 2011, ...
8 years, 5 months ago (2012-07-24 16:49:54 UTC) #2
messick
Brian should take a look at the core mods.
8 years, 5 months ago (2012-07-24 16:57:46 UTC) #3
Brian Wilkerson
8 years, 5 months ago (2012-07-24 17:13:55 UTC) #4 
The core changes LGTM

Powered by Google App Engine
This is Rietveld 408576698