Issue 10815067: Disable mirror tests on Dartium to fix the build. TBR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10815067: Disable mirror tests on Dartium to fix the build. TBR. (Closed)

Created:
8 years, 5 months ago by rmacnak

Modified:
8 years, 5 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disable mirror tests on Dartium to fix the build. TBR. Committed: https://code.google.com/p/dart/source/detail?r=9833

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/lib/lib.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM. But unless you are fixing the test failures within a day or so please ...

8 years, 5 months ago (2012-07-23 23:52:44 UTC) #1

rmacnak

8 years, 5 months ago (2012-07-24 00:07:17 UTC) #2

The mirror tests make the invalid assumption that the library with
the tests will be the root library at run time. They should instead
get the library mirror by name. I should be able to fix this today.

On 2012/07/23 23:52:44, Ivan Posva wrote:
> LGTM.
> 
> But unless you are fixing the test failures within a day or so please explain
> why you are skipping the tests at the moment in a comment.
> 
> -Ivan

Expand Messages | Collapse Messages