Issue 10809089: Make sure the "Skip*" functions know about cascades as well.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10809089: Make sure the "Skip*" functions know about cascades as well. (Closed)

Created:
8 years, 5 months ago by hausner

Modified:
8 years, 5 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Make sure the "Skip*" functions know about cascades as well. Also, handle index operator in cascades correctly. Committed: https://code.google.com/p/dart/source/detail?r=9910

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -58 lines)			Patch
M	runtime/vm/parser.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	12 chunks	+45 lines, -50 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

rmacnak

The test is checked in now. On 2012/07/24 23:29:06, srdjan wrote: > LGTM, but I ...

8 years, 5 months ago (2012-07-25 17:46:44 UTC) #3

hausner

Major addition to this change: handle index operator in cascades correctly. PTAL, thank you.

8 years, 5 months ago (2012-07-25 20:50:14 UTC) #4

lgtm