Issue 10808111: Move more symbols to the vm isolate.

Issue 10808111: Move more symbols to the vm isolate. (Closed)

Created:
8 years, 5 months ago by siva

Modified:
8 years, 5 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Move more symbols to the vm isolate. Committed: https://code.google.com/p/dart/source/detail?r=9905

Patch Set 5 : #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -109 lines)			Patch
M	vm/code_generator.cc	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	vm/object.cc	View	1 2 3 4	3 chunks	+3 lines, -3 lines	0 comments	Download
M	vm/parser.h	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	vm/parser.cc	View	1 2 3 4	38 chunks	+64 lines, -85 lines	0 comments	Download
M	vm/scanner.cc	View	1 2 3 4	1 chunk	+4 lines, -4 lines	0 comments	Download
M	vm/scopes.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/symbols.h	View	1 2 3 4	3 chunks	+55 lines, -4 lines	0 comments	Download
M	vm/symbols.cc	View	1 2 3 4	3 chunks	+20 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM with comments. -Ivan https://chromiumcodereview.appspot.com/10808111/diff/14001/vm/symbols.h File vm/symbols.h (right): https://chromiumcodereview.appspot.com/10808111/diff/14001/vm/symbols.h#newcode40 vm/symbols.h:40: V(StringClass, "StringBase") \ StringClass -> ...

8 years, 5 months ago (2012-07-25 17:56:51 UTC) #3

siva

8 years, 5 months ago (2012-07-25 20:30:53 UTC) #4

https://chromiumcodereview.appspot.com/10808111/diff/14001/vm/symbols.h
File vm/symbols.h (right):

https://chromiumcodereview.appspot.com/10808111/diff/14001/vm/symbols.h#newco...
vm/symbols.h:40: V(StringClass, "StringBase")                                   
             \
On 2012/07/25 17:56:51, Ivan Posva wrote:
> StringClass -> StringBase to update for the moved class name since the
> originating code had been written.

Done.

https://chromiumcodereview.appspot.com/10808111/diff/14001/vm/symbols.h#newco...
vm/symbols.h:73: static RawString* symbol() { return predefined_[k##symbol]; }
Yes I was thinking about that too. We already create ZoneHandles for a number of
these so having the handles in the VM isolate would be perfect.

On 2012/07/25 17:56:51, Ivan Posva wrote:
> I am wondering whether we should return handles here instead of RawString. And
> preallocate these handles in the VM isolate. Not necessarily in this CL
though.

Expand Messages | Collapse Messages