Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 10808099: Always set inserted range in List.insertRange. (Closed)

Created:
8 years, 5 months ago by Anders Johnsen
Modified:
8 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Always set inserted range in List.insertRange. This fixes a bug where myList.insertRange(x, y, null) would fail to set the new range to null. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=9855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M runtime/lib/growable_array.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Anders Johnsen
8 years, 5 months ago (2012-07-24 12:20:30 UTC) #1
floitsch
8 years, 5 months ago (2012-07-24 13:18:28 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698